search

asagi4 / comfyui-prompt-control

ComfyUI nodes for prompt editing and LoRA control
GNU General Public License v3.0
210 stars 16 forks source link

Does this work with SD 1.5? #14

Closed cliffrowley closed 1 year ago

cliffrowley commented 1 year ago

I loaded up the example workflow and tried it with a SD 1.5 checkpoint, but it throws an error from prepareXL. Is this an XL only node? (I didn't see anything in the docs that says so, but I could have easily missed it!)

asagi4 commented 1 year ago

I just happened to push a fix for this issue a few moments ago.

ComfyUI has changed its token datastructure and that caused the extension to detect SD 1.5 as SDXL if you had the advanced clip extension installed. If you update your extension it should work.

Though be warned, there were some sampling changes to ComfyUI yesterday and today that might have also broken things; My ComfyUI is currently at commit c837a173fab41b7132a72ab01b256b714bd6adb2 because the changes break AITemplate, and I very much like the speedup AIT gives me.

cliffrowley commented 1 year ago

Wonderful, thank you so much!

Edit: I'll report back later when I get a chance to test and let you know it works here too.

asagi4 commented 1 year ago

I fixed AIT for recent ComfyUI and things seem to work normally, so I'm closing this issue.

cliffrowley commented 1 year ago

All works just fine here, thank you for your efforts!