asam-ev / OpenMATERIAL

3D model exchange format with physical material properties for virtual development, test and validation of automated driving.
https://asam-ev.github.io/OpenMATERIAL/
Mozilla Public License 2.0
14 stars 7 forks source link

134 complete chapter road network structure 735 #180

Closed lyndyRott closed 2 days ago

lyndyRott commented 1 week ago

Describe your changes

According to the information in issue #134, I extended the documentation of the environment by

Changes:

What has changed:

Questions:

General:

Categories: Buildings, Vegetation, Other:

Issue ticket number and link

134

Mention a member

Please review the first trial thematically (and the correctness of the adoc standard, as I am not familiar): @LudwigFriedmann @ipg-sig

Checklist

FKlopfer commented 1 week ago

@LudwigFriedmann , should we perform a linguistic review now or wait until further feedback is provided?

ClemensLinnhoff commented 1 week ago

@LudwigFriedmann , should we perform a linguistic review now or wait until further feedback is provided?

I just did some cleanup. Now it is ready for editorial review @FKlopfer. There are some coordinate definitions and all images missing, but let's tackle that in a separate PR.

lyndyRott commented 4 days ago

Thank you, Clemens, for doing the clean-up. I was not sure, if I should do it.

The coordinate definitions will be added by Ludwig. It makes sense to do this in a new branch, probably?!

Concerning images, I do not have any 3D visualizations for the defined classes (which are free of 3rd party IP). Maybe someone with more experience in generating these can support?

ClemensLinnhoff commented 4 days ago

Yes, let's do the coordinates in a separate branch. The images can be done by @ACMackenthun after we have done the coordinate definitions, also in a separate branch.

ClemensLinnhoff commented 4 days ago

So, after the editorial review by @FKlopfer we can directly merge this branch.

LudwigFriedmann commented 4 days ago

@lyndyRott and @ClemensLinnhoff: I'd also vote for a merge after the review by @FKlopfer . I'll add the coordinate frames afterwards.

mettelilienthal commented 2 days ago

@ClemensLinnhoff @LudwigFriedmann @lyndyRott I've done the editorial review.