search

asam-ev / qc-openscenarioxml

6 stars 3 forks source link

Add trailer connect test to improve allowed operator check #36

Closed romanodanilo closed 2 months ago

romanodanilo commented 2 months ago

Description

With the execution of all osc checkers on standard examples, it emerged a problem with TrailerConnect.xosc

 Summary:        
        Error:      #0: Issue flagging invalid operand is used within expression
                    Invalid operand -$Speed used
        Error:      #1: Issue flagging invalid operand is used within expression
                    Invalid operand /$TrajRadius used
        Error:      #2: Issue flagging invalid operand is used within expression
                    Invalid operand /$TrajRadius used

The expression parsing needed to be fixed to treat variables as such

Fixed also a typo in one negative example that was causing one issue more to be triggered

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.
  2. Added specific test for the case arisen. OK.

Notes