search

asciidisco / grunt-imagine

Grunt tasks for optimizing & inlining images
MIT License
153 stars 21 forks source link

(inlineImg) Rewrite of main loop #56

Closed cybear closed 9 years ago

cybear commented 10 years ago

Utilize an object FileMeta to contain everything needed for each file.

It keeps the original path and supplies helper functions to do everything necessary with each file.

Use functional style to filter the file list

asciidisco commented 10 years ago

This looks good to me; would love to have some thoughts form @LaurentGoderre @alpadev.

LaurentGoderre commented 10 years ago

Looks good but I wonder if you could extract the class to a separate file and import it with require()

cybear commented 10 years ago

That sounds fair. It could possibly be useful for other modules if they had a similar rewrite. If I do that, will that be enough for the pull request to go through?

LaurentGoderre commented 10 years ago

I,.m trying to figure out while the build fail but when it passes sure

LaurentGoderre commented 10 years ago

Oh, could you write tests for the new class? I think tests are also useful for other developers to see how a class like this works

cybear commented 10 years ago

For the builds it seems like we have some quite old versions of various dependencies. I can bump the dependencies - but I can't promise that I will be able to test that everything still works though. What do you think is a good solution?

OK will add unit tests to my todo list.

LaurentGoderre commented 10 years ago

Ok, try to bump the dependencies but could you do it in a separate PR?

asciidisco commented 10 years ago

Any news on this?

cybear commented 10 years ago

Sorry, I didn't find any time in my vacation to do this. My spare time is limited but I hope to start looking into it soon.

On Sat, Jun 28, 2014 at 5:27 PM, Sebastian Golasch <notifications@github.com

wrote:

Any news on this?

— Reply to this email directly or view it on GitHub https://github.com/asciidisco/grunt-imagine/pull/56#issuecomment-47430232 .

Björn Söderqvist http://copenhagenjs.dk http://modl.se http://demodag.org

asciidisco commented 10 years ago

No worries. I know that feeling. Take your time :)

asciidisco commented 9 years ago

@cybear Forgotten about this? (So did I ;) ). Any news?

cybear commented 9 years ago

Oops! Yes I have. Unfortunately I'm not using Grunt anymore at work and I don't think I will find any time to tamper with this in my spare time.