search

asciidisco / plugin.video.netflix

Inputstream based Netflix plugin for Kodi
MIT License
1.23k stars 225 forks source link

[Subtitles] Unnecessary newlines added #62

Open Dis90 opened 7 years ago

Dis90 commented 7 years ago

Like some videos I can see subtitles for 3 minutes and then nothing but in some videos subtitles stops working after 1 minute and then shows randomly.

I've been watching this show '13 reasons why' and it seems like plugin is showing subtitles only for lines what narrator speaks.

Long debug log with ffmpeg and video components logging: http://paste.ubuntu.com/24422205/

Ubuntu: 14.04 Kodi: 2f67109 Inputstream: a7e84de Netflix-plugin: v0.11.11

Uukrull commented 7 years ago

That's because the inputstream.adaptive addon only takes into account lines with the "span" tag and ignores the rest. This commit from me fixes that and adds support for italics:

https://github.com/Uukrull/inputstream.adaptive/commit/3fe7a6656d3f2e3debb19204311e72bce6cae95c

Dis90 commented 7 years ago

Thanks for quick reply. I compiled your agile_fix branch of inputstream.adaptive and subtitles seems to work now.

asciidisco commented 7 years ago

@Uukrull @liberty-developer Do you know if this resolved in the Kodi Nightlies (and included inputstream) now?

Uukrull commented 7 years ago

Yes, it's solved. The only problem now is that, sometimes, extras lines are added:

Removing this line fixes the issue:

asciidisco commented 7 years ago

@Uukrull Thank you. I´ll send your comment to @liberty-developer

asciidisco commented 7 years ago

Issue is reported, but may take some time to find its way into inputstream. Renaming this one for the time being.