search

asciidoctor / asciidoctor-firefox-addon

:wolf: An add-on for Mozilla Firefox that converts AsciiDoc files to HTML directly in the browser using Asciidoctor.js.
https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/
MIT License
32 stars 9 forks source link

Publish on AMO #9

Closed ggrossetie closed 9 years ago

ggrossetie commented 10 years ago

Rejected again yesterday because the code is "obfuscated":

Your add-on, Asciidoctor.js Live Preview 0.1.4, has been reviewed by an editor and did not meet the criteria for being hosted in our gallery.

Reviewer: Kris Maglione

Comments: This version contains binary, obfuscated or minified code. We need to review all of your source code in order to approve it. Please send the following items to amo-admin-sources@mozilla.com:

• A link to your add-on listing. • Whether you're nominating this version for Full Review or Preliminary Review. • The source files of your add-on, either as an attachment or a link to a downloadable package. Sources archives may be in any of the following formats: zip, 7z, tar, tar.gz, tar.bz2, or tar.xz. They man not be provided using proprietary archive formats, including RAR and DMG. • For updates, including the source code of the previously approved version or a diff is also helpful.

We will re-enable your rejected version once we have reviewed the code. You can read our policies regarding source code handling here: https://addons.mozilla.org/en-US/developers/docs/policies/reviews#section-binary.

mojavelinux commented 10 years ago

We can put a non-minified version of asciidoctor.js and opal.js into the extension. Since it's local, there's really no need to minify anyway.

When we cut a 1.5.0 preview version (hopefully in a few days) we'll push the raw version into the FF add-on.

ggrossetie commented 10 years ago

The code is not minified but I think that the AMO don't like "generated" Javascript. I replied with an explanation on how things are built. Le 27 nov. 2013 00:33, "Dan Allen" notifications@github.com a écrit :

We can put a non-minified version of asciidoctor.js and opal.js into the extension. Since it's local, there's really no need to minify anyway.

When we cut a 1.5.0 preview version (hopefully in a few days) we'll push the raw version into the FF add-on.

— Reply to this email directly or view it on GitHubhttps://github.com/asciidoctor/asciidoctor-firefox-addon/issues/9#issuecomment-29346142 .

mojavelinux commented 10 years ago

We'll have to warm them up to it. We are pioneers. Time to break new ground. As the popularity of Opal grows, there will be others for whom we will pave the path.

ggrossetie commented 10 years ago

I discussed on IRC this week with an AMO reviewer. Kris Maglione will hopefully be on IRC this Monday so I'll have a chance to explain him all the greatness about Opal and Asciidoctor :smile:

mojavelinux commented 10 years ago

Great news! Definitely be sure to have them get in touch with @adambenyon if the conversation seems to be slipping away. It's definitely in Opal's best interest to get this approval.

I also might know some fine folks at Mozilla that I could nag ;)

mojavelinux commented 10 years ago

Good luck!

ggrossetie commented 10 years ago

Didn't go too well... I just have to wait for their decision.

empathy over process

ggrossetie commented 10 years ago

Any news ? :cry:

mojavelinux commented 10 years ago

Hey Guillaume!

I haven't forgotten about this, but I haven't had a chance to follow up on it yet either. I'll move it up in the priority list, see if I can get the ball rolling by next week.

akhayyat commented 10 years ago

Is this going to happen?

The README says:

Install extension from Firefox Add-ons site or [...]

But it's not available there!

ggrossetie commented 10 years ago

Is this going to happen? Hopefully... Maybe... I don't know... That's a good question :smile:

The AMO is a long process and I'm currently 42/109 in the queue (I submitted the add-on four weeks ago). The first submission (10 months ago) didn't go well because the Javascript generated by Opal was judged "obfuscated". After discussing and pleading my case on the forum or via email I decided to try again, let's see how it goes...

The add-on is not indexed but you can install it from https://addons.mozilla.org/fr/firefox/addon/asciidoctorjs-live-preview/

You can also a review to help get it approved :+1:

mojavelinux commented 10 years ago

Here's the english version of the add-on page:

https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/

I found that you have to go into the DOM inspector and uncheck the style pointer-events: none on the link so you can click it.

mojavelinux commented 10 years ago

I found that you have to go into the DOM inspector and uncheck the style pointer-events: none on the link so you can click it.

Oh, that might of been because I am using Chrome. Duh.

ggrossetie commented 10 years ago

@mojavelinux Any news ? Still in the queue 32 of 169... maybe we can add a link on asciidoctor.org ?

mojavelinux commented 10 years ago

@Mogztter No news yet. I'll note it down to follow up.

maybe we can add a link on asciidoctor.org ?

Definitely. Send a PR and I'll merge it in.

...which reminds me, we still need to rewrite this page to include a section about the browser plugins: http://asciidoctor.org/docs/editing-asciidoc-with-live-preview/ We could even consider just having a separate guide. Best place to start is an outline.

ggrossetie commented 9 years ago

AMO review is endless... I published my add-on 2 months, 3 weeks ago!

mojavelinux commented 9 years ago

:confounded:

Btw, still no word from Mozilla mgmt.

(It almost makes me wonder if the community should counter with an alternate market to apply pressure).

ggrossetie commented 9 years ago

Or they could use the community to do the review by voting or reporting add-ons. There are just not enough volunteers to review all the add-ons.

I don't know how Opera manage to review add-ons in days... I believe they have full time employees to do the review. Le 23 nov. 2014 11:17, "Dan Allen" notifications@github.com a écrit :

[image: :confounded:]

Btw, still no word from Mozilla mgmt.

(It almost makes me wonder if the community should counter with an alternate market to apply pressure).

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-firefox-addon/issues/9#issuecomment-64113002 .

ggrossetie commented 9 years ago

@mojavelinux "5 months in the queue" https://forums.mozilla.org/viewtopic.php?f=21&t=22584

mojavelinux commented 9 years ago

When I read that response, I feel a lot of a pain. But at least it ends on a promising note.

Thanks for the feedback. We'll try to get to your add-on soon, so please be patient.

We can be grateful for something, I suppose ;)

ggrossetie commented 9 years ago

And done! :tada: https://addons.mozilla.org/en-US/firefox/addon/asciidoctorjs-live-preview/

mojavelinux commented 9 years ago

:beers: and lots of them! Congrats!