search

asciidoctor / asciidoctor-mathematical

An extension for Asciidoctor that converts the content of STEM blocks and inline macros using Mathematical.
MIT License
50 stars 45 forks source link

Implemented AsciiMath support #82

Closed GarkGarcia closed 4 years ago

GarkGarcia commented 4 years ago

This is a follow up to #79. I followed the instructions provided in https://github.com/asciidoctor/asciidoctor-mathematical/issues/79#issuecomment-623044299, but I'm not quite sure I made all necessary alterations, since I don't really have a solid understanding of code-base.

@ProgramFan Could you take a look?

GarkGarcia commented 4 years ago

I had a hard time understanding what is going on in here:

https://github.com/asciidoctor/asciidoctor-mathematical/blob/f81c3a0d3e4ea9fe10fa223010267b1239a030e5/lib/asciidoctor-mathematical/extension.rb#L135

GarkGarcia commented 4 years ago

For reference, the idea of this PR is to use asciidoctor/asciimath to convert AsciiMath to LaTeX and then render it as an image with Mathematical.

Here are some notes on the LaTeX outputted by asciidoctor/asciimath:

https://github.com/asciidoctor/asciimath#notes-on-the-latex-output

tstumm commented 4 years ago

Travis CI had some hickups, seems like the build passes now.

@ProgramFan What do you think?

ProgramFan commented 4 years ago

Thanks for your contribution. With this PR, asciidoctor-mathemtical can now handle all types of stems defined in asciidoc.

GarkGarcia commented 4 years ago

Thanks for your contribution. With this PR, asciidoctor-mathemtical can now handle all types of stems defined in asciidoc.

Great! Thanks!

When could I expect the changes to be released in RubyGems?

tstumm commented 4 years ago

See https://rubygems.org/gems/asciidoctor-mathematical/