search

asciidoctor / asciidoctor-reveal.js

:crystal_ball: A reveal.js converter for Asciidoctor and Asciidoctor.js. Write your slides in AsciiDoc!
http://asciidoctor.org
Other
287 stars 189 forks source link

Checklist: Checkboxes missing when Fontawesome enabled for icons #526

Open thomas-ferchau opened 5 months ago

thomas-ferchau commented 5 months ago

When enabling Fontawesome for icons (:icons: font), checklists do not contain any checkboxes:

checklist-missing-checkboxes

Checkboxes are shown without Fontawesome - but not scaled with the font (see #451):

checklist-default-ok

Workarounds that I use:

Workaround 1: Replace icon class icon-check with far fa-check-square and icon-check-empty with far fa-square in docinfo-footer-revealjs.html:

checklist-workaround1

Workaround 2: Remove bullets and improve spacing in custom CSS (does not look nice for mixed lists, but I do not use those):

checklist-workaround2

Possible fixes:

thomas-ferchau commented 5 months ago

The example file and workarounds can be found in this repository for reproducing the problem: https://github.com/thomas-ferchau/asciidoctor-revealjs-checklist-bug

thomas-ferchau commented 5 months ago

If someone can confirm that the change (replacing the icon classes) would be fine, I could of course create a pull request for that.

ggrossetie commented 2 months ago

@thomas-ferchau sorry for the late reply but yes you can submit a pull request. As you've mentioned checklists currently do not look great and we should improve it.

Your second proposal is great. You can take a look at: https://docs.asciidoctor.org/asciidoc/latest/lists/checklist/ which is very close to your second proposal.