search

asciidoctor / atom-asciidoc-preview

⚛ AsciiDoc preview for the Atom editor.
https://atom.io/packages/asciidoc-preview
MIT License
141 stars 42 forks source link

Add additional values to toc option #252

Open mojavelinux opened 7 years ago

mojavelinux commented 7 years ago

Description

The toc option currently does not reflect all the possible values. It's missing:

The current "none" value is acting as the "not-specified" value, but it is not clear enough to the user that this is what the option means. In fact, I would prefer the name "not set" for this value as this terminology is consistent with the Asciidoctor user manual.

If we decide to rename "not-specifed" to "not set", then we should also change the corresponding value for the section numbering option.

ldez commented 7 years ago

Today we have 3 options:

https://github.com/asciidoctor/atom-asciidoc-preview/blob/fd76a3e0c3ac8184a45c67933eada8a5564c2850/package.json#L79-L90

In the code: https://github.com/asciidoctor/atom-asciidoc-preview/blob/fd76a3e0c3ac8184a45c67933eada8a5564c2850/lib/configuration-builder.coffee#L21-L30

Do you want me to add 2 new options and rename none tonot-set?