search

asciidoctor / atom-asciidoc-preview

⚛ AsciiDoc preview for the Atom editor.
https://atom.io/packages/asciidoc-preview
MIT License
141 stars 42 forks source link

Save as HTML context menu item not working in Atom 1.24 #258

Closed kachkaev closed 6 years ago

kachkaev commented 6 years ago

Save as HTML... context menu item seems to be broken after upgrading to Atom 1.24.0, which was released two days ago. Clicking on this menu item displays a window to choose a file name, but then nothing happens. Strangely, there are no exceptions in Atom's console or any other signs of an error.

A shortcut for this menu item (which is cmd+shift+s) does not produce HTML files either – the behaviour is the same.

The issue has been confirmed on two machines where Save as HTML... worked in Atom 1.23.3.

/cc @jsndyks

ldez commented 6 years ago

Seems to be a regression in Atom with showSaveDialogSync

https://github.com/atom/atom/blob/2923f0057f5acec94f638546432f50e9a027da0c/src/atom-environment.js#L1179-L1184

https://github.com/atom/atom/pull/16245