search

asciidoctor / docbookrx

(An early version of) a DocBook to AsciiDoc converter written in Ruby.
MIT License
22 stars 49 forks source link

enable warnings when running rspec #49

Closed mojavelinux closed 8 years ago

mrietveld commented 8 years ago

@mojavelinux I've been pushing some commits directly to docbookrx -- for example, see https://github.com/asciidoctor/docbookrx/commit/646419d1a068fd3f8149f679272fcf45a2297bbd.

Should I make sure to submit everything as a pull-request?

mojavelinux commented 8 years ago

@mrietveld Yes, please. That's essentially the culture of the Asciidoctor project. I also find it to be a very effective technique for reviewing my own work. This is another good point for the planned contributing guide, so I'll add it to the issue I'm creating.

mojavelinux commented 8 years ago

If you'd like to avoid the merge commit, you can use the "squash and merge" feature that GitHub provides.