Upcoming updates to this package

[ArtemKolichenkov]

Upcoming updates to this package

Hello everybody!
Thanks to @ascoders I've become a maintainer for this repo and related repo react-native-image-viewer

I have some free time now to go through issues and provide some fixes/features. I will spend around 2 hours each day working on this project, hopefully bringing it to a better shape by June.

Rough idea for the current major version of this package is:

• [X] Update tooling (e.g. adopt ESLint since TSLint is deprecated, as well as other devX improvements)
• [ ] Go through PRs
• [ ] Go through Issues looking which ones make sense to implement, address questions, fix bugs, etc.
• [ ] Incorporate changelog
• [ ] Update documentation
• [ ] Maybe make better demo project to test things out + some automated tests

All backwards-compatible changes will be released under 2.2.x version.

After that work is done I'd like to go away from class-based component to functional component + hooks since it is the modern (and the future) way to write React and it is also easier to read and reason about code. Especially for "small" components like this one.
But I'd suggest to leave it for future major release 3.x.x since even though it probably gonna be backwards-compatible it would be a nice way to mark the point in time for this kind of major refactoring step (we might also plug in some non-backwards-compatible stuff at this point too).

Let's use this issue as a discussion topic.

I will also update this top comment with the progress status:
13.05.2020
Made a cleanup branch for basic cleanup (ESLint, dependency updates, etc.)
15.05.2020

• Improved demo app to test things out (+repaired it, it was broken due to old expo version).
• Refactored deprecated methods
• Merged/adopted some PRs

19.05.2020
Released version 2.1.12 to npm Read release notes here

P.S. I know it sounds like a big update and you want to run npm update react-native-image-pan-zoom already, but please be patient, since I can't work all day on this some updates can take a bit of time before they reach npm.

[Fallup]

Sounds great! I'd love to see Prettier 2.0 thrown in as part of basic tooling cleanup/update. As for the road map it looks ok. Maybe it would be worth to consider if rewrite to react-native-reanimated + react-native-gesture-handler makes sense for a major future release.

[ArtemKolichenkov]

@Fallup Prettier 2.0 is in :) Yeah, reanimated would be nice since apparently Animated has some issues, especially with low-end devices.

@ascoders I've made a cleanup PR #130 with some non-breaking changes and small improvements (no big new features). Feel free to review if you have time.

But most importantly, I can't publish new versions on npm, so what should we do about that? I can ping you here when I think there are enough fixes to publish a new version, but I'm not sure how often you check this repo. If you could give me, this is my npmjs user profile - https://www.npmjs.com/~artemkolichenkov

Have no idea how to share permissions though. But I'm fine with you publishing it if you can check here once in a while.

Also it would be nice to install allcontributors bot to this repo to put people's names on Readme. I don't think I can do it for this repo, would be nice if you could do that :)

[ascoders]

@ArtemKolichenkov thanks for your work! You have been given npm collaborator for these two packages. And allcontributors has been installed to this repo.

[ArtemKolichenkov]

UPDATE: Released version 2.1.12 to npm Read release notes here

[ArtemKolichenkov]

Small "update" - haven't been able to work for the last couple of days on this repo, will continue now, sorry for the lack of action.

[ArtemKolichenkov]

Hi again! I was quite busy since my last comment, had to move and change job this summer. Today is my last day at current job btw so I will have some time and energy to come back to this repo 🙂 Again sorry for delay.