asdf-community / asdf-crystal

Crystal plugin for the asdf version manager
https://github.com/asdf-vm/asdf
Apache License 2.0
75 stars 16 forks source link

CI build is failing, missing Authorization token #18

Closed daniel-illi closed 4 years ago

daniel-illi commented 5 years ago

Currently the CI build is failing because list-all does not send an Authorization token on the request to github. Running the ci command locally gives the following error output:

$ asdf plugin-test crystal https://github.com/marciogm/asdf-crystal.git 'crystal -v'
Cloning into '/tmp/asdf.VWjZ'...
done.
Note: checking out '1886e00cf18f5e9d3c5ac1bd18426d04121d4472'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

Cloning into '/tmp/asdf.VWjZ/plugins/crystal'...
remote: Enumerating objects: 59, done.
remote: Total 59 (delta 0), reused 0 (delta 0), pack-reused 59
Unpacking objects: 100% (59/59), done.

Looks like crystal/bin/list-all relies on GitHub releases
but it does not properly sets an Authorization header to prevent
GitHub API rate limiting.

See https://github.com/asdf-vm/asdf/blob/master/docs/creating-plugins.md#github-api-rate-limiting
FAILED: crystal/bin/list-all does not set GitHub Authorization token
smorimoto commented 4 years ago

Fixed in latest master.