search

asdf-community / asdf-flutter

flutter plugin for the asdf version manager
https://github.com/asdf-vm/asdf
MIT License
111 stars 31 forks source link

Remove channel suffix from version specification #2

Closed raels0 closed 4 years ago

raels0 commented 4 years ago

https://github.com/oae/asdf-flutter/blob/b136e675d57c9c083c92902c259e285c7154d8a8/bin/install#L23

There should only be one channel per version at any one time, hence it seems redundant to append the channel to the version then check that matches with user input. This is also is different from the asdf norm, my preference would simply to limit it to comparing version[1:] with the user input.

This means that installing the latest version would change from inputting "1.12.13+hotfix.5-stable" to simply "1.12.13+hotfix.5".

oae commented 4 years ago

As I check the versions, There are multiple channels for the same version like this;

    {
      "hash": "27321ebbad34b0a3fafe99fac037102196d655ff",
      "channel": "stable",
      "version": "v1.12.13+hotfix.5",
      "release_date": "2019-12-11T15:48:44.133001Z",
      "archive": "stable/linux/flutter_linux_v1.12.13+hotfix.5-stable.tar.xz",
      "sha256": "d792c92895623da35e1a9ccd8bc2fe84c81dd72c2c54073f56fe70625866d800"
    },
    {
      "hash": "27321ebbad34b0a3fafe99fac037102196d655ff",
      "channel": "beta",
      "version": "v1.12.13+hotfix.5",
      "release_date": "2019-12-11T02:46:38.389095Z",
      "archive": "beta/linux/flutter_linux_v1.12.13+hotfix.5-beta.tar.xz",
      "sha256": "fec59dff786265626d4e340a5d4d0e0774085155f38755983a2a485aa4a3dd50"
    },

I think user should choose which channel they want when installing them.