search

asednev / homebridge-plugin-govee

Govee H-series Thermometer Hygrometer plugin for Homebrige.
Apache License 2.0
53 stars 9 forks source link

Combine with homebridge-govee #69

Open bwp91 opened 2 years ago

bwp91 commented 2 years ago

Hi @asednev

I’m the dev of homebridge-govee plugin.

I wondered how you would feel about combining the functionality of your plugin into mine?

Id be happy to do it myself, but Id obviously be using your code.

Please let me know how you’d feel about this, i would totally understand if you wish to keep your plugin separate. So far I have always directed my users to your plugin for these sensors which are bluetooth only.

Thanks! Ben

asednev commented 2 years ago

Hi @bwp91,

Combining two Govee plugings will certainly make it easier for the end users. I think it's an awesome idea!

My plugin has been in a fairly steady state for 12+ months. I am absolutely open to collaboration especially if someone can take this plugin to new heights.

bwp91 commented 2 years ago

Thanks for the quick reply. Great! I also think it would be great for users to have a unified experience with one plugin for everything

haty1 commented 1 year ago

This is a great idea! Any update?

bwp91 commented 1 year ago

This is a great idea! Any update?

starting looking into this today

bwp91 commented 1 year ago

that was nice and easy in fact there is a beta published already.

the caveat at the moment is that your govee username and password are required as this is how my plugin is setup and it will currently only accept scan results for existing accessories from your account

bwp91 commented 1 year ago

@asednev the govee-bt-client was very easy to work with great job there.

I feel like I am gonna have an influx of new issues in my plugin now about new models. Do you have any guide about how someone can get some ble logs, what data is needed and how it can be implemented into the client?

asednev commented 1 year ago

@bwp91 sorry for late reply. govee-bt-client library exposes debug function which allows to enable logs within. That's your best tool to troubleshoot ble devices. If you think there's a better way to get to ble logs or your need more fidelity, feel free to raise a PR against govee-bt-client repo and tag me on it.

bwp91 commented 1 year ago

@bwp91 sorry for late reply. govee-bt-client library exposes debug function which allows to enable logs within. That's your best tool to troubleshoot ble devices. If you think there's a better way to get to ble logs or your need more fidelity, feel free to raise a PR against govee-bt-client repo and tag me on it.

thanks! i’ve been thinking it would be nice to be able to specify a custom log function for the library. basically so i can input the homebridge log function. will look into a PR. unless it’s something you would be able to do more quickly