search

ashik94vc / ElegantNumberButton

Widget which acts as a number counter which changes its number on +/- press.
Apache License 2.0
180 stars 62 forks source link

Complile time exception #9

Open isabsent opened 7 years ago

isabsent commented 7 years ago

Please, remove android:icon="@mipmap/ic_launcher" from your library! I have a compile time exception

Error:Execution failed for task ':app:processDebugManifest'.
Manifest merger failed : Attribute application@icon value=(@mipmap/cashbox) from AndroidManifest.xml:30:9-39
is also present at [com.cepheuen.elegant-number-button:lib:1.0.2] AndroidManifest.xml:13:9-43 value=(@mipmap/ic_launcher).
Suggestion: add 'tools:replace="android:icon"' to <application> element at AndroidManifest.xml:27:5-56:19 to override.
ashik94vc commented 7 years ago

Can you do that and submit a pull request ? I'll merge it.

On Mon, Sep 4, 2017, 12:44 AM isabsent notifications@github.com wrote:

Please, remove android:icon="@mipmap/ic_launcher" from your library! I have a compile time exception `Error:Execution failed for task ':app:processDebugManifest'.

Manifest merger failed : Attribute application@icon value=() from AndroidManifest.xml:30:9-39 is also present at [com.cepheuen.elegant-number-button:lib:1.0.2] AndroidManifest.xml:13:9-43 value=(). Suggestion: add 'tools:replace="android:icon"' to element at AndroidManifest.xml:27:5-56:19 to override.`

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ashik94vc/ElegantNumberButton/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyZR2aXpj4bgWfbHmceAP69Hbv4swWIks5se4AzgaJpZM4PLc7n .

-- Ashik Vetrivelu

isabsent commented 7 years ago

I have no idea how to do it. Never did it before, sorry. But you can just remove all entries from application tag in the lib manifest ElegantNumberButton/lib/src/main/AndroidManifest.xml i.e. set

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.cepheuen.elegantnumberbutton">
</manifest>

instead of

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.cepheuen.elegantnumberbutton">

    <application
        android:allowBackup="true"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
       android:supportsRtl="true"
       android:theme="@style/AppTheme">
    </application>

</manifest>
ashik94vc commented 7 years ago

I'll look into these sometime this weekend.

Thanks, Ashik Vetrivelu

On Sep 4, 2017 2:57 AM, "isabsent" notifications@github.com wrote:

I have no idea how to do it. Never did it before, sorry. But you can just remove all entries from application tag in the lib manifest ElegantNumberButton/lib/src/main/AndroidManifest.xml i.e. set

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.cepheuen.elegantnumberbutton">

instead of

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.cepheuen.elegantnumberbutton">

<application
    android:allowBackup="true"
    android:icon="@mipmap/ic_launcher"
    android:label="@string/app_name"
   android:supportsRtl="true"
   android:theme="@style/AppTheme">
</application>

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/ashik94vc/ElegantNumberButton/issues/9#issuecomment-326880892, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyZRwlW122o6o-tLUzOhLtajRSF90a_ks5se59ZgaJpZM4PLc7n .

Orpheus007 commented 6 years ago

I'm having the same problem as above, is there a way to fix this?

siddharthcse7 commented 6 years ago

Facing same issue

kparitosh21 commented 6 years ago

Not able to import your library, :( Not able to make an object of it in class

isabsent commented 6 years ago

@Lightning-Bug Try this fork.