search

ashok-khanna / RPN-30

GNU General Public License v2.0
1 stars 2 forks source link

Added the page of trig functions accessed with TRIG. Rearranged keypad #12

Closed michaelaoash closed 4 years ago

michaelaoash commented 4 years ago

I took advantage of the fact that all the trig functions are actually unary to write a very simple ADV.FN interface (which I called TRIG) that should get the stack adjustment right (by not flagging the trig functions as unary). Because the trig functions are unary, it is possible to avoid managing the t register. Please let me know if this works.

I also rearranged the keypad more.

ashok-khanna commented 4 years ago

Dear Michael,

I've merged your latest commit into the branch, all went smoothly and very straightforward. Some minor syntax changes but it compiled perfectly on first go. GitHub has been a great experience, it was my first collaborative experience and I can see why its used by so many programmers. I read an interview on the linux kernel development, they however like to use only e-mail for version control, which sounds crazy (noting that GitHub actually arose from git which arose from the linux kernel project back in the late 90s I believe). I'm sure they have some git in there, but it is predominantly e-mail! Crazy.

I'm uploading to TestFlight, so hopefully you will see it in the next 48 hours (although tends to be within 24 hours from the last few examples).

The trig function works well (and nice idea on taking advantage of its unary nature).

SPOILER PLEASE DON'T READ THE FOLLOWING UNTIL YOU HAVE TESTED THE CALCULATOR SPOILER

Although it feels a little bit unnatural to me to do the following to calculate sin(45) in the following manner.

45 ENTER 1 ENTER TRIG

(although that was what the idea was)

Instead, on my first attempt I automatically did:

45 ENTER TRIG

and then my brain got confused

Let me know what your experience was. Once I figured out how to use it, it was straightforward, but I think it might not be the most intuitive way. I think the most intuitive might actually be (the below actually works due to the way the button triggers are setup, although you can't do consecutive TRIG functions in the below manner):

45 ENTER TRIG (Long press similar to STORE/RECALL) 1

Thanks, Ashok

From: Michael Ash notifications@github.com Sent: Saturday, 18 April 2020 9:29 PM To: premier-education/RPN-30 RPN-30@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [premier-education/RPN-30] Added the page of trig functions accessed with TRIG. Rearranged keypad (#12)

I took advantage of the fact that all the trig functions are actually unary to write a very simple ADV.FN interface (which I called TRIG) that should get the stack adjustment right (by not flagging the trig functions as unary). Because the trig functions are unary, it is possible to avoid managing the t register. Please let me know if this works.

I also rearranged the keypad more.

You can view, comment on, or merge this pull request online at:

https://github.com/premier-education/RPN-30/pull/12https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013315598&sdata=WTndxEefji5yvPbKN%2Bps77CUpjjXyuDkqTSk8reL39Y%3D&reserved=0

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=%2F4dqzH2FFFAOqxJtTbOvjeP94%2BPFfz8BooPpVKe2qvg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALEWW23YVEYDMXK2RI2HNKDRNGFLPANCNFSM4MLKCTCA&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=IuMS16ediHpOTXOvH1okBtVt%2FPcfPLcdnD6fr%2F7%2BeHg%3D&reserved=0.

michaelaoash commented 4 years ago

Dear Ashok,

I've got the new version and it's brilliant. Thanks again!

I think that for the example you gave you would need to convert Degrees to Radians first (because sin(), etc., operate on Radians).

45 ENTER 8 TRIG 1 TRIG which is equivalent to: 7 TRIG 4 DIV 1 TRIG and both worked exactly as expected.

Try, for example, 45 ENTER 8 TRIG 3 TRIG for tan(45)

I'm having a little trouble getting the rhythm going (pressing the number for too long, TRIG for not long enough, etc.) but once I have my head wrapped around it, it goes fast.

It's totally cool that TRIG also works as a "chord" like STORE/RECALL. I would suggest swapping x! to keypad #4 and TRIG to keypad #7 so that for the simultaneous press, the displaced TRIG function is pi (on keypad #7) rather than asin() (on keypad #4). I can do that and make a pull request if you like the idea.

I think that this is near perfect. (How is life without % Delta? Dare I ask?)

Can we invite my brother Andrew Ash andrewash9@gmail.com to the beta test? He's a very sharp person and will probably have good observations.

Thanks again!

All best, Michael

On Sun, Apr 19, 2020 at 12:13 PM Ashok Khanna notifications@github.com wrote:

Dear Michael,

I've merged your latest commit into the branch, all went smoothly and very straightforward. Some minor syntax changes but it compiled perfectly on first go. GitHub has been a great experience, it was my first collaborative experience and I can see why its used by so many programmers. I read an interview on the linux kernel development, they however like to use only e-mail for version control, which sounds crazy (noting that GitHub actually arose from git which arose from the linux kernel project back in the late 90s I believe). I'm sure they have some git in there, but it is predominantly e-mail! Crazy.

I'm uploading to TestFlight, so hopefully you will see it in the next 48 hours (although tends to be within 24 hours from the last few examples).

The trig function works well (and nice idea on taking advantage of its unary nature).

SPOILER PLEASE DON'T READ THE FOLLOWING UNTIL YOU HAVE TESTED THE CALCULATOR SPOILER

Although it feels a little bit unnatural to me to do the following to calculate sin(45) in the following manner.

45 ENTER 1 ENTER TRIG

(although that was what the idea was)

Instead, on my first attempt I automatically did:

45 ENTER TRIG

and then my brain got confused

Let me know what your experience was. Once I figured out how to use it, it was straightforward, but I think it might not be the most intuitive way. I think the most intuitive might actually be (the below actually works due to the way the button triggers are setup, although you can't do consecutive TRIG functions in the below manner):

45 ENTER TRIG (Long press similar to STORE/RECALL) 1

Thanks, Ashok

From: Michael Ash notifications@github.com Sent: Saturday, 18 April 2020 9:29 PM To: premier-education/RPN-30 RPN-30@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [premier-education/RPN-30] Added the page of trig functions accessed with TRIG. Rearranged keypad (#12)

I took advantage of the fact that all the trig functions are actually unary to write a very simple ADV.FN interface (which I called TRIG) that should get the stack adjustment right (by not flagging the trig functions as unary). Because the trig functions are unary, it is possible to avoid managing the t register. Please let me know if this works.

I also rearranged the keypad more.

You can view, comment on, or merge this pull request online at:

https://github.com/premier-education/RPN-30/pull/12< https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013315598&sdata=WTndxEefji5yvPbKN%2Bps77CUpjjXyuDkqTSk8reL39Y%3D&reserved=0

Commit Summary

  • Added the page of trig functions accessed with TRIG. Also rearranged keypad
  • Added the page of trig functions accessed with TRIG. Also rearranged keypad

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub< https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=%2F4dqzH2FFFAOqxJtTbOvjeP94%2BPFfz8BooPpVKe2qvg%3D&reserved=0>, or unsubscribe< https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALEWW23YVEYDMXK2RI2HNKDRNGFLPANCNFSM4MLKCTCA&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=IuMS16ediHpOTXOvH1okBtVt%2FPcfPLcdnD6fr%2F7%2BeHg%3D&reserved=0

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/premier-education/RPN-30/pull/12#issuecomment-616172636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZJT7LTHB2TSCTHCUILVDRNMPI7ANCNFSM4MLKCTCA .

-- Michael Ash, Professor of Economics and Public Policy Member of MSP/MTA/NEA, the union of faculty and librarians University of Massachusetts Amherst Email mash@econs.umass.edu Tel +1-413-545-6329

ashok-khanna commented 4 years ago

Dear Michael,

That's great to hear! I've mapped TRIG to 7 and x! to 4 to assist with that.

Thank you for your input, it was definitely helped improve the calculator. With your help, this has converted from a basic calculator to something that can rival scientific calculators on the iPhone.

Life without % Delta has been painful 😉 I reinstall the old version or use my other phone for it haha.

I found a way to add configuration options into the settings page (when you go iPhone --> settings --> then there are settings for each app).

This way I don't need to create a new settings page within the app, which will save a bit of work and can easily set up some simple settings to change the configuration - I think I will keep it as two versions - "scientific", based on your configuration, and "normal" based on % Delta and anything else I think would make sense there. I no longer want to have % and % TOT, so have two free functions, but at the same time I don't really need trig functions in a 'normal' calculator. x! may be useful for permutations and combinations. Perhaps I might add some financial functions instead and then have it as 'scientific' and 'financial'. Perhaps an IRR and NPV calc.

Most certainly, I will add your brother Andrew to the test. Unfortunately, Apple servers are down so I will have to try again tomorrow to process the new build and also to add Andrew. He will receive an e-mail automatically.

Cheers, Ashok

From: Michael Ash notifications@github.com Sent: Tuesday, 21 April 2020 6:36 AM To: premier-education/RPN-30 RPN-30@noreply.github.com Cc: Ashok Khanna ashok.khanna@hotmail.com; State change state_change@noreply.github.com Subject: Re: [premier-education/RPN-30] Added the page of trig functions accessed with TRIG. Rearranged keypad (#12)

Dear Ashok,

I've got the new version and it's brilliant. Thanks again!

I think that for the example you gave you would need to convert Degrees to Radians first (because sin(), etc., operate on Radians).

45 ENTER 8 TRIG 1 TRIG which is equivalent to: 7 TRIG 4 DIV 1 TRIG and both worked exactly as expected.

Try, for example, 45 ENTER 8 TRIG 3 TRIG for tan(45)

I'm having a little trouble getting the rhythm going (pressing the number for too long, TRIG for not long enough, etc.) but once I have my head wrapped around it, it goes fast.

It's totally cool that TRIG also works as a "chord" like STORE/RECALL. I would suggest swapping x! to keypad #4 and TRIG to keypad #7 so that for the simultaneous press, the displaced TRIG function is pi (on keypad #7) rather than asin() (on keypad #4). I can do that and make a pull request if you like the idea.

I think that this is near perfect. (How is life without % Delta? Dare I ask?)

Can we invite my brother Andrew Ash andrewash9@gmail.com to the beta test? He's a very sharp person and will probably have good observations.

Thanks again!

All best, Michael

On Sun, Apr 19, 2020 at 12:13 PM Ashok Khanna notifications@github.com wrote:

Dear Michael,

I've merged your latest commit into the branch, all went smoothly and very straightforward. Some minor syntax changes but it compiled perfectly on first go. GitHub has been a great experience, it was my first collaborative experience and I can see why its used by so many programmers. I read an interview on the linux kernel development, they however like to use only e-mail for version control, which sounds crazy (noting that GitHub actually arose from git which arose from the linux kernel project back in the late 90s I believe). I'm sure they have some git in there, but it is predominantly e-mail! Crazy.

I'm uploading to TestFlight, so hopefully you will see it in the next 48 hours (although tends to be within 24 hours from the last few examples).

The trig function works well (and nice idea on taking advantage of its unary nature).

SPOILER PLEASE DON'T READ THE FOLLOWING UNTIL YOU HAVE TESTED THE CALCULATOR SPOILER

Although it feels a little bit unnatural to me to do the following to calculate sin(45) in the following manner.

45 ENTER 1 ENTER TRIG

(although that was what the idea was)

Instead, on my first attempt I automatically did:

45 ENTER TRIG

and then my brain got confused

Let me know what your experience was. Once I figured out how to use it, it was straightforward, but I think it might not be the most intuitive way. I think the most intuitive might actually be (the below actually works due to the way the button triggers are setup, although you can't do consecutive TRIG functions in the below manner):

45 ENTER TRIG (Long press similar to STORE/RECALL) 1

Thanks, Ashok

From: Michael Ash notifications@github.com Sent: Saturday, 18 April 2020 9:29 PM To: premier-education/RPN-30 RPN-30@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [premier-education/RPN-30] Added the page of trig functions accessed with TRIG. Rearranged keypad (#12)

I took advantage of the fact that all the trig functions are actually unary to write a very simple ADV.FN interface (which I called TRIG) that should get the stack adjustment right (by not flagging the trig functions as unary). Because the trig functions are unary, it is possible to avoid managing the t register. Please let me know if this works.

I also rearranged the keypad more.

You can view, comment on, or merge this pull request online at:

https://github.com/premier-education/RPN-30/pull/12< https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013315598&sdata=WTndxEefji5yvPbKN%2Bps77CUpjjXyuDkqTSk8reL39Y%3D&reserved=0

Commit Summary

  • Added the page of trig functions accessed with TRIG. Also rearranged keypad
  • Added the page of trig functions accessed with TRIG. Also rearranged keypad

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub< https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=%2F4dqzH2FFFAOqxJtTbOvjeP94%2BPFfz8BooPpVKe2qvg%3D&reserved=0>, or unsubscribe< https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALEWW23YVEYDMXK2RI2HNKDRNGFLPANCNFSM4MLKCTCA&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=IuMS16ediHpOTXOvH1okBtVt%2FPcfPLcdnD6fr%2F7%2BeHg%3D&reserved=0

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/premier-education/RPN-30/pull/12#issuecomment-616172636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZJT7LTHB2TSCTHCUILVDRNMPI7ANCNFSM4MLKCTCA .

-- Michael Ash, Professor of Economics and Public Policy Member of MSP/MTA/NEA, the union of faculty and librarians University of Massachusetts Amherst Email mash@econs.umass.edu Tel +1-413-545-6329

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12%23issuecomment-616794546&data=02%7C01%7C%7C0ff9c1b80d274e33b47c08d7e56a7c05%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230117886460782&sdata=nZkYgROTw0xoosMQFN52JtLmC93kP0QYs084ueZvdW8%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALEWW2674HQ5B4GN2POHKP3RNSW4HANCNFSM4MLKCTCA&data=02%7C01%7C%7C0ff9c1b80d274e33b47c08d7e56a7c05%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230117886470779&sdata=U1TBcKCjRlW1cbLQH1QwApF5YCTZYTHk4D2599XSwHI%3D&reserved=0.

michaelaoash commented 4 years ago

Dear Ashok,

Thank you again for developing this great calculator. It's really the best RPN calculator for iOS. I look forward to introducing it to my students, etc. I had a fun time with the github collaboration.

That's very nifty that you can specify different formulations in the App settings. (I've put out a call to the IT minor at UMass that I'll supervise a couple of credits of independent study if anyone wants to write the drag and drop. No answer so far, but I'll let you know.)

I think that bond yield from price, maturity, coupon, and par OR price from maturity, coupon, par, and interest rate would be a good pair of features for the financial version. For ideas: https://www.hpmuseum.org/hp12c.htm (I'd be happy to test...)

All best, Michael

On Tue, Apr 21, 2020 at 3:18 PM Ashok Khanna notifications@github.com wrote:

Dear Michael,

That's great to hear! I've mapped TRIG to 7 and x! to 4 to assist with that.

Thank you for your input, it was definitely helped improve the calculator. With your help, this has converted from a basic calculator to something that can rival scientific calculators on the iPhone.

Life without % Delta has been painful 😉 I reinstall the old version or use my other phone for it haha.

I found a way to add configuration options into the settings page (when you go iPhone --> settings --> then there are settings for each app).

This way I don't need to create a new settings page within the app, which will save a bit of work and can easily set up some simple settings to change the configuration - I think I will keep it as two versions - "scientific", based on your configuration, and "normal" based on % Delta and anything else I think would make sense there. I no longer want to have % and % TOT, so have two free functions, but at the same time I don't really need trig functions in a 'normal' calculator. x! may be useful for permutations and combinations. Perhaps I might add some financial functions instead and then have it as 'scientific' and 'financial'. Perhaps an IRR and NPV calc.

Most certainly, I will add your brother Andrew to the test. Unfortunately, Apple servers are down so I will have to try again tomorrow to process the new build and also to add Andrew. He will receive an e-mail automatically.

Cheers, Ashok

From: Michael Ash notifications@github.com Sent: Tuesday, 21 April 2020 6:36 AM To: premier-education/RPN-30 RPN-30@noreply.github.com Cc: Ashok Khanna ashok.khanna@hotmail.com; State change < state_change@noreply.github.com> Subject: Re: [premier-education/RPN-30] Added the page of trig functions accessed with TRIG. Rearranged keypad (#12)

Dear Ashok,

I've got the new version and it's brilliant. Thanks again!

I think that for the example you gave you would need to convert Degrees to Radians first (because sin(), etc., operate on Radians).

45 ENTER 8 TRIG 1 TRIG which is equivalent to: 7 TRIG 4 DIV 1 TRIG and both worked exactly as expected.

Try, for example, 45 ENTER 8 TRIG 3 TRIG for tan(45)

I'm having a little trouble getting the rhythm going (pressing the number for too long, TRIG for not long enough, etc.) but once I have my head wrapped around it, it goes fast.

It's totally cool that TRIG also works as a "chord" like STORE/RECALL. I would suggest swapping x! to keypad #4 and TRIG to keypad #7 so that for the simultaneous press, the displaced TRIG function is pi (on keypad #7) rather than asin() (on keypad #4). I can do that and make a pull request if you like the idea.

I think that this is near perfect. (How is life without % Delta? Dare I ask?)

Can we invite my brother Andrew Ash andrewash9@gmail.com to the beta test? He's a very sharp person and will probably have good observations.

Thanks again!

All best, Michael

On Sun, Apr 19, 2020 at 12:13 PM Ashok Khanna notifications@github.com wrote:

Dear Michael,

I've merged your latest commit into the branch, all went smoothly and very straightforward. Some minor syntax changes but it compiled perfectly on first go. GitHub has been a great experience, it was my first collaborative experience and I can see why its used by so many programmers. I read an interview on the linux kernel development, they however like to use only e-mail for version control, which sounds crazy (noting that GitHub actually arose from git which arose from the linux kernel project back in the late 90s I believe). I'm sure they have some git in there, but it is predominantly e-mail! Crazy.

I'm uploading to TestFlight, so hopefully you will see it in the next 48 hours (although tends to be within 24 hours from the last few examples).

The trig function works well (and nice idea on taking advantage of its unary nature).

SPOILER PLEASE DON'T READ THE FOLLOWING UNTIL YOU HAVE TESTED THE CALCULATOR SPOILER

Although it feels a little bit unnatural to me to do the following to calculate sin(45) in the following manner.

45 ENTER 1 ENTER TRIG

(although that was what the idea was)

Instead, on my first attempt I automatically did:

45 ENTER TRIG

and then my brain got confused

Let me know what your experience was. Once I figured out how to use it, it was straightforward, but I think it might not be the most intuitive way. I think the most intuitive might actually be (the below actually works due to the way the button triggers are setup, although you can't do consecutive TRIG functions in the below manner):

45 ENTER TRIG (Long press similar to STORE/RECALL) 1

Thanks, Ashok

From: Michael Ash notifications@github.com Sent: Saturday, 18 April 2020 9:29 PM To: premier-education/RPN-30 RPN-30@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [premier-education/RPN-30] Added the page of trig functions accessed with TRIG. Rearranged keypad (#12)

I took advantage of the fact that all the trig functions are actually unary to write a very simple ADV.FN interface (which I called TRIG) that should get the stack adjustment right (by not flagging the trig functions as unary). Because the trig functions are unary, it is possible to avoid managing the t register. Please let me know if this works.

I also rearranged the keypad more.

You can view, comment on, or merge this pull request online at:

https://github.com/premier-education/RPN-30/pull/12<

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013315598&sdata=WTndxEefji5yvPbKN%2Bps77CUpjjXyuDkqTSk8reL39Y%3D&reserved=0

Commit Summary

  • Added the page of trig functions accessed with TRIG. Also rearranged keypad
  • Added the page of trig functions accessed with TRIG. Also rearranged keypad

File Changes

  • M RPN-30/InitializeButtons.swift<

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12%2Ffiles%23diff-3d9430f9f2831bbaafdec9616991c4a5&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013315598&sdata=FZ4MJNIhdKjaFjUmsOu6QJIe16gKlSRehYbb1XGJ7%2FA%3D&reserved=0>

(16)

  • M RPN-30/LogicEngine.swift<

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12%2Ffiles%23diff-026f0dec18ae7fc63099e6ede91fbe5e&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013315598&sdata=XTV%2FzduVeS6vxPfZA5tiCQXsfW3ozkXprgnUonGEbj0%3D&reserved=0>

(89)

  • M RPN-30/OutputDisplay.swift<

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12%2Ffiles%23diff-6c046d00fcb7d9296d54f38df9e97e7e&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013325590&sdata=YgbO2vMDvl4H%2FR5rkBdXg9x2wAZFi%2BJoTk6%2FnQdCNc4%3D&reserved=0>

(42)

Patch Links:

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12.patch&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013325590&sdata=zoTWuTxZwFiUvE9Ztv317XjQ6%2BFbf%2FKHcEJOxzHGpUE%3D&reserved=0

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12.diff&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=CBpPYYIIGVCYAOzxw1oPl1h6SVjiHDdGqZs0u9DnWrI%3D&reserved=0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=%2F4dqzH2FFFAOqxJtTbOvjeP94%2BPFfz8BooPpVKe2qvg%3D&reserved=0>,

or unsubscribe<

https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALEWW23YVEYDMXK2RI2HNKDRNGFLPANCNFSM4MLKCTCA&data=02%7C01%7C%7C4afdfbb8494b436c6c8108d7e38bd4ba%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637228062013335584&sdata=IuMS16ediHpOTXOvH1okBtVt%2FPcfPLcdnD6fr%2F7%2BeHg%3D&reserved=0

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/premier-education/RPN-30/pull/12#issuecomment-616172636>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAFZJT7LTHB2TSCTHCUILVDRNMPI7ANCNFSM4MLKCTCA>

.

-- Michael Ash, Professor of Economics and Public Policy Member of MSP/MTA/NEA, the union of faculty and librarians University of Massachusetts Amherst Email mash@econs.umass.edu Tel +1-413-545-6329

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub< https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpremier-education%2FRPN-30%2Fpull%2F12%23issuecomment-616794546&data=02%7C01%7C%7C0ff9c1b80d274e33b47c08d7e56a7c05%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230117886460782&sdata=nZkYgROTw0xoosMQFN52JtLmC93kP0QYs084ueZvdW8%3D&reserved=0>, or unsubscribe< https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALEWW2674HQ5B4GN2POHKP3RNSW4HANCNFSM4MLKCTCA&data=02%7C01%7C%7C0ff9c1b80d274e33b47c08d7e56a7c05%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637230117886470779&sdata=U1TBcKCjRlW1cbLQH1QwApF5YCTZYTHk4D2599XSwHI%3D&reserved=0>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/premier-education/RPN-30/pull/12#issuecomment-617361591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZJT3YDZRCZHKV3BVKS5LRNXWPRANCNFSM4MLKCTCA .

-- Michael Ash, Professor of Economics and Public Policy Member of MSP/MTA/NEA, the union of faculty and librarians University of Massachusetts Amherst Email mash@econs.umass.edu Tel +1-413-545-6329