Gitlab plugin does not handle subgroups

[ahmadou]

Hi,

I'm facing an issue when i get a 404 error whenever i try to create a new scm plugin entry. The plugin only works with "simple" urls but don't want to work when the repo si within a subgroup in gitlab.

After reviewing the code of https://github.com/ashwanthkumar/gocd-build-github-pull-requests/blob/master/src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java and https://github.com/ashwanthkumar/gocd-build-github-pull-requests/blob/12df90579b0951519f4cf49567d9cf9ca3205234/src/main/java/in/ashwanthkumar/gocd/github/provider/github/GHUtils.java#L24 i think i understand the cause of my problem.

The plugin currently can only handle urls like these : protocol / host / username / repo seeing the algorithm in the method parseGithubUrl.

But a url like this is a perfectly valid gitlab url : protocol / host / group1/ subgroup1 / subgroup2/ repo

The code could be fixed to try to account for that but why can't we just provide the project id as an additional parameter considering that the Gitlab api client can handle it and that that information is readily available in the gitlab interface ?

I don't know the full consequences of replacing the project url parameter but i think it would be less intrusive to add an optional parameter with the project id.

If i want to make a contribution is there some documentation i could follow since the issue is quite pressing for me?

[darynsteelsword]

Was a fix ever made for this, pls?

[ahmadou]

Hi, I made a fix for this a long time ago see : https://github.com/ashwanthkumar/gocd-build-github-pull-requests/pull/154