search

asjqkkkk / markdown_widget

📖Rendering markdown by flutter！Welcome for pr and issue.
MIT License
312 stars 90 forks source link

Fix `\t` Being Removed #160

Closed PeronGH closed 6 months ago

PeronGH commented 6 months ago

As mentioned in #159, there is a bug causing \t being removed. This PR fixed it. If there is any problem with this PR, please let me know.

asjqkkkk commented 6 months ago

Hi @PeronGH , thanks for your pull request

removing \t directly indeed solves this problem. However, this RegExp is always hard-coded. I believe a better approach would be to pass this RegExp externally, while providing a default RegExp internally. If it's convenient for you, you can make these changes in this pull request, or I can merge it first and handle it later when I have time.

PeronGH commented 6 months ago

removing \t directly indeed solves this problem. However, this RegExp is always hard-coded. I believe a better approach would be to pass this RegExp externally, while providing a default RegExp internally. If it's convenient for you, you can make these changes in this pull request, or I can merge it first and handle it later when I have time.

I agree that a more flexible approach would be better. Unfortunately, I'm not familiar enough with the project's structure and API design to make those changes confidently. Would you be willing to provide guidance, or merge the pull request as-is and you can address the changes later?