Missing tooltip translation

askvortsov1 / flarum-rich-text

MIT License

17 stars 6 forks source link

Missing tooltip translation #3

Closed imorland closed 3 years ago

imorland commented 3 years ago

Looking at https://github.com/flarum/core/blob/11b1ab593226a2412913892d7c7850e0e379dcc1/locale/core.yml#L286

This key should be core.forum.composer.preview_tooltip?

rob006 commented 3 years ago

This key should be core.forum.composer.preview_tooltip?

This translation should not be used directly in the first place. AFAIK every context should use unique key.

https://github.com/askvortsov1/flarum-rich-text/blob/7fe9acf6145fcc5d3b7ec6ca77940a6674f6c5f3/js/src/common/applyEditor.js#L27

Also I'm not sure what is the BC policy for translations in Flarum core. Could Flarum remove some unused keys in minor/patch release? That could break extensions that use these keys.