search

asny / three-d

2D/3D renderer - makes it simple to draw stuff across platforms (including web)
MIT License
1.34k stars 110 forks source link

Egui gizmo example #432

Closed paul2t closed 10 months ago

paul2t commented 10 months ago

PR to use the latest version of egui : 0.25.0 I also added an example usage of egui-gizmo, based on the existing demo.

KaranJain21 commented 10 months ago

Seems super useful! Is there a timeline for when this will get merged?

paul2t commented 10 months ago

@KaranJain21 While waiting for it to be merged, you can edit the dependency to three-d in your Cargo.toml three-d = { git = "https://github.com/paul2t/three-d.git", branch = "egui-0.25", features = [ "egui-gui" ] } You could also fork the repository and merge the changes you need.

asny commented 10 months ago

I cherry picked updating egui to a new PR so that can get in right away (thanks for the contribution 🙏 ).

I'm not sure about the egui-gizmo example, what is the purpose of that example? (Seems a bit unrelated to three-d)

paul2t commented 10 months ago

I thought it would be useful to show an example of 3d manipulation using the three-d engine. It took me some time to figure out how to do it. I thought other people would like to have an example like I would have liked. Where do you think I should share this example instead ?

asny commented 10 months ago

@paul2t I very much appreciate the effort! 🙏 If it was free to add new examples, I would have accepted it right away. However, it's not free, I have to update all examples whenever I do a breaking change, I have to test them when I do a release and I have to keep the dependencies up to date (this example adds two new dependencies 😬 ). So my question is, what feature of three-d does this example cover that is not part of other examples? 🤔 I know it shows how to combine egui-gizmo with three-d but there's a lot of crates that could be combined with three-d which would lead to a lot of examples not really related to three-d. Maybe it's relevant in the egui-gizmo crate?

paul2t commented 10 months ago

Ok I understand, no problem. I will share it with the egui-gizmo crate then. Thanks for your time.