search

aspect-build / rules_js

High-performance Bazel rules for running Node.js tools and building JavaScript projects
https://docs.aspect.build/rules/aspect_rules_js
Apache License 2.0
310 stars 107 forks source link

fix(npm): replace npm_translate_lock(replace_packages) with replace_package module extension #1886

Open jbedard opened 3 months ago

jbedard commented 3 months ago

A replacement of the npm_translate_lock(replace_packages) API for bzlmod to ensure labels are passed from the user module instead of strings.

Changes are visible to end-users: no

Test plan

aspect-workflows[bot] commented 3 months ago

Test

All tests were cache hits

193 tests (100.0%) were fully cached saving 48s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 631ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 516ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 925ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 925ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 184ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 55ms.

Test

e2e/npm_translate_lock_replace_packages

:warning: Buildkite build #5561 failed.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 167ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 507ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 16s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 7s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 4s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 324ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 562ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 251ms.

Buildifier      Format