aspect-build / rules_js

High-performance Bazel rules for running Node.js tools and building JavaScript projects
https://docs.aspect.build/rules/aspect_rules_js
Apache License 2.0
310 stars 107 forks source link

Jtatasciore/lint #1910

Open JesseTatasciore opened 2 months ago

JesseTatasciore commented 2 months ago

Changes are visible to end-users: yes/no

Test plan

aspect-workflows[bot] commented 2 months ago

Test

:warning: Buildkite build #5752 failed.

Failed tests (1)
//npm/private/test:write_npm_translate_lock_bzlmod_0_test [k8-fastbuild]                 128ms

:bulb: To reproduce the test failures, run

bazel test //npm/private/test:write_npm_translate_lock_bzlmod_0_test

Test

e2e/bzlmod

Buildkite build #5752 is running...


Test

e2e/gyp_no_install_script

Buildkite build #5752 is running...


Test

e2e/js_image_oci

Buildkite build #5752 is running...


Test

e2e/npm_link_package

Buildkite build #5752 is running...


Test

e2e/npm_link_package-esm

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_empty

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_multi

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_partial_clone

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_replace_packages

Buildkite build #5752 is running...


Test

e2e/npm_translate_lock_subdir_patch

Buildkite build #5752 is running...


Test

e2e/npm_translate_package_lock

Buildkite build #5752 is running...


Test

e2e/npm_translate_yarn_lock

Buildkite build #5752 is running...


Test

e2e/package_json_module

Buildkite build #5752 is running...


Test

e2e/pnpm_lockfiles

Buildkite build #5752 is running...


Test

e2e/pnpm_workspace

Buildkite build #5752 is running...


Test

e2e/pnpm_workspace_rerooted

Buildkite build #5752 is running...


Test

e2e/repo_mapping

Buildkite build #5752 is running...


Test

e2e/rules_foo

Buildkite build #5752 is running...


Test

e2e/vendored_node

Buildkite build #5752 is running...


Buildifier

Buildifier managed files require formatting

--- ./BUILD.bazel   2024-08-29 01:24:52.818567397 +0000
+++ /tmp/buildifier-tmp-553689284   2024-08-29 01:25:52.538788707 +0000
@@ -138,4 +138,4 @@
     name = "prettierrc",
     srcs = [".prettierrc.cjs"],
     visibility = ["//visibility:public"],
-)
\ No newline at end of file
+)

:bulb: Run the following to apply the suggested formatting fixes

bazel run //:buildifier

Format

Formatting check has failed

:bulb: Some formatting failures can be fixed automatically by running the command below, while others may require manual fixes

bazel run //:format -- .prettierrc.cjs BUILD.bazel eslint.config.mjs foo.json

:information_source: A patch file containing the changes has been archived as an artifact of this build


Lint