search

aspect-build / rules_js

High-performance Bazel rules for running Node.js tools and building JavaScript projects
https://docs.aspect.build/rules/aspect_rules_js
Apache License 2.0
310 stars 107 forks source link

doc: add callout for dependency on generate_bzl_library_targets #1911

Closed plobsing closed 2 months ago

plobsing commented 2 months ago

When this attribute is not set in the call to npm_translate_lock, the queries return no results, the package_json.bzl file is not directly findable, and users may be very confused.

Changes are visible to end-users: no

Test plan

Manually confirmed the queries work after setting this setting but not before. See also https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1724827171385349 .

aspect-workflows[bot] commented 2 months ago

Test

All tests were cache hits

193 tests (100.0%) were fully cached saving 38s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 1s.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 236ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 839ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 745ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 296ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 112ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 716ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 192ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 713ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 233ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 141ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 171ms.

Buildifier      Format