search

aspect-build / rules_js

High-performance Bazel rules for running Node.js tools and building JavaScript projects
https://docs.aspect.build/rules/aspect_rules_js
Apache License 2.0
310 stars 107 forks source link

fix(npm): respect npm_package include_transitive_sources attribute #1912

Closed jbedard closed 2 months ago

jbedard commented 2 months ago

Changes are visible to end-users: no

Test plan

aspect-workflows[bot] commented 2 months ago

Test

7 test targets passed

Targets 
//npm/private/test/npm_package:test_pkg [k8-fastbuild]                                   61ms
//npm/private/test/npm_package:test_pkg_2 [k8-fastbuild]                                 61ms
//npm/private/test/npm_package:test_pkg_3 [k8-fastbuild]                                 77ms
//npm/private/test/npm_package:test_pkg_4 [k8-fastbuild]                                 69ms
//npm/private/test/npm_package:test_pkg_5 [k8-fastbuild]                                 71ms
//npm/private/test/npm_package:test_pkg_6 [k8-fastbuild]                                 61ms
//npm/private/test/npm_package:test_pkg_with_node_modules [k8-fastbuild]                 56ms

Total test execution time was 456ms. 190 tests (96.4%) were fully cached saving 38s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 1s.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 236ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 839ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 745ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 27ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 296ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 112ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 716ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 192ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 81ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 713ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 233ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 141ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 171ms.

Buildifier      Format