search

aspnet / AspNetWebStack

ASP.NET MVC 5.x, Web API 2.x, and Web Pages 3.x (not ASP.NET Core)
Other
858 stars 354 forks source link

Use `msbuild` from VS 2022 if available #395

Closed dougbu closed 1 year ago

dougbu commented 1 year ago
dougbu commented 1 year ago

@wtgodbe I normally don't worry too much about this repo's build and test flakiness. In this case however, I seem to have changed timings enough for some incorrect assemblies to land in bin/$(Configuration)/Test/ (causing assembly load issues in Moq) and for significantly increased port reservation issues e.g. System.ServiceModel.AddressAlreadyInUseException : HTTP could not register URL http://localhost:50235/ because TCP port 50235 is being used by another application.

My efforts so far haven't worked and I may back out my latest (xUnit collection) commit. In the meantime, I'm going to try another thing or two. First, calling in the big guns…

@halter73 @Tratcher could you please have a look at the logic in the PortReserver class❔ I don't see anything obviously wrong in it and was surprised the xUnit collection approach didn't help much. I suspect there's something fundamentally wrong. Note however that the class iseems to be used correctly i.e., instances are disposed everywhere they should be.

dougbu commented 1 year ago

I forgot to mention: The issues related to PortReserver aren't new in this PR. It's more that retrying builds doesn't seem to work these days.

dougbu commented 1 year ago

Oh, wow, that worked. Suspect gremlins will crop up again but merging for now.

@Tratcher and @halter73, it's less urgent but your thoughts may help during the long live of this repo.

dougbu commented 1 year ago

Somewhat predictably, build #20230306.4 immediately after this PR validated on its first attempt for this iteration failed w/ lots of port reservation problems. Hopefully there's something in PortReserver that jumps out at you @Tratcher and @halter73.