Separate Microsoft.TestCommon more

aspnet / AspNetWebStack

ASP.NET MVC 5.x, Web API 2.x, and Web Pages 3.x (not ASP.NET Core)

Other

858 stars 354 forks source link

Separate Microsoft.TestCommon more #400

Closed dougbu closed 1 year ago

dougbu commented 1 year ago

pre-restore and prebuild the project before anything that depends on it
- avoid references from other test projects doing any real work
make ordering even more explicit
- avoid confusion between batching builds and $(BuildInParallel)
turns out this also reduces the number of double writes binary logs show significantly

dougbu commented 1 year ago

Unfortunately, the PortReserver issues are still hurting in AzDO builds. I don't see them nearly as much in TeamCity (oddly enough). /cc @halter73 @Tratcher

dougbu commented 1 year ago

TeamCity builds were the ones where I mainly saw problems w/ Microsoft.TestCommon. Using this branch, TeamCity builds #561 and #563 of Main.Integration was successful.

Tratcher commented 1 year ago

Trying to find a free port like that will always be racy. It's better for the server to retry binding until it finds a port.

dougbu commented 1 year ago

Trying to find a free port like that will always be racy. It's better for the server to retry binding until it finds a port.

Thanks @Tratcher. Doesn't help my frustration w/ getting this PR in :wink: May either force the merge or just keep retrying until things work. I'm also open to adding a tactical fix here. I'm fine no matter the choice but am not going to dive into finding that workaround myself.