search

aspnet / Benchmarks

Benchmarks for ASP.NET Core
Other
1.17k stars 238 forks source link

Proxy GRPC benchmarks broken #2013

Open sebastienros opened 1 month ago

sebastienros commented 1 month ago

Obsolete method need to be updated.

dotnet publish GrpcClient.csproj -c Release -o /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/perf/benchmarkapps/GrpcClient/published /p:MicrosoftNETCoreAppPackageVersion=9.0.0-rc.1.24408.12 /p:MicrosoftAspNetCoreAppPackageVersion=9.0.0-rc.1.24407.10 /p:GenerateErrorForMissingTargetingPacks=false /p:RestoreNoCache=true /p:MicrosoftNETPlatformLibrary=Microsoft.NETCore.App --framework net9.0 --self-contained -r linux-x64 
  Determining projects to restore...
  Restored /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/perf/benchmarkapps/GrpcClient/GrpcClient.csproj (in 3.31 sec).
  Restored /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/src/Grpc.Core.Api/Grpc.Core.Api.csproj (in 3.33 sec).
  Restored /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/src/Grpc.Net.Common/Grpc.Net.Common.csproj (in 7.16 sec).
  Restored /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/src/Grpc.Net.Client/Grpc.Net.Client.csproj (in 7.16 sec).
  Grpc.Core.Api -> /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/src/Grpc.Core.Api/bin/Release/netstandard2.1/Grpc.Core.Api.dll
  Grpc.Net.Common -> /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/src/Grpc.Net.Common/bin/Release/net8.0/Grpc.Net.Common.dll
  Grpc.Net.Client -> /tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/src/Grpc.Net.Client/bin/Release/net8.0/Grpc.Net.Client.dll
/tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/perf/benchmarkapps/GrpcClient/Program.cs(479,45): error SYSLIB0057: 'X509Certificate2.X509Certificate2(string, string?)' is obsolete: 'Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certificates.' (https://aka.ms/dotnet-warnings/SYSLIB0057) [/tmp/benchmarks-agent/benchmarks-server-1/69DA5B955F78EDDC/perf/benchmarkapps/GrpcClient/GrpcClient.csproj]
sebastienros commented 1 month ago

@JamesNK don't bother if you are busy, will do it tomorrow otherwise

sebastienros commented 1 month ago

https://github.com/grpc/grpc-dotnet/pull/2502

I believe the change is too recent in the runtime to get a valid build in grpc-dotnet.