Use Selenium to test Chrome

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

2.63k stars 528 forks source link

Use Selenium to test Chrome #3084

Closed JunTaoLuo closed 5 years ago

JunTaoLuo commented 5 years ago

Addresses https://github.com/aspnet/KestrelHttpServer/issues/3075 I still want to evaluate whether this version is more reliable. It ended up being a test only change so I was hoping to resolve the flakiness in 2.2 as well.

JunTaoLuo commented 5 years ago

I've ran the converted Selenium tests 50 times without seeing any failures. Previously I was seeing a test failure with headless chrome 1 in 10-20 runs. It also turns out Selenium tests run faster in 8.6 seconds vs 11.4 seconds before the change.

JunTaoLuo commented 5 years ago

ping @halter73 @Tratcher

JunTaoLuo commented 5 years ago

cc @muratg this is the change we'd like to make in 2.2 to make headless chrome tests more stable.