Infer `BindingSource.Body` for collection types (again)

aspnet / Mvc

[Archived] ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

5.62k stars 2.14k forks source link

Infer `BindingSource.Body` for collection types (again) #8658

Closed dougbu closed 5 years ago

dougbu commented 5 years ago

8536 and changes #7712 resolution
do not infer string.Empty prefix for collections of simple types
also correct ModelMetadata.IsComplexType doc comments

nits:

make InferBoundPropertyModelPrefixes(...) and InferParameterModelPrefixes(...) conditions consistent
correct InferBindingSourceForParameter_ReturnsQueryForSimpleTypes() name
shorten a few lines

dougbu commented 5 years ago

@pranavkm bump ⛰

(As discussed offline, this remains relevant when your new compat switch is off or the user doesn't add a binding attribute.)

dougbu commented 5 years ago

Closing because @pranavkm is going to mix fixing the inferred BindingSource into his coming "stop when we see any BindingInfo" PR. Will reassign the bugs to him.

@pranavkm do you need my dougbu/collections.again.7712.8536 branch?

aspnet / Mvc

Infer `BindingSource.Body` for collection types (again) #8658

8536 and changes #7712 resolution