search

aspnet / SignalR

[Archived] Incredibly simple real-time web for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
2.38k stars 446 forks source link

Fix dynamic require for Webpack #3306

Closed BrennanConroy closed 6 years ago

BrennanConroy commented 6 years ago

Fixes https://github.com/aspnet/SignalR/issues/3254

@muratg We'd like to discuss the release timeline for this fix as it's a broken scenario when using Angular 6+.

BrennanConroy commented 6 years ago

@anurse Couldn't extract this into a function as webpack needs to know the string value passed into require otherwise it complains.

analogrelay commented 6 years ago

it's a broken scenario when using Angular 6+

It's also a regression. 2.1 did not have this problem and would have worked from Angular 6.

muratg commented 6 years ago

Also, should this go to master? Or does master not have this problem?

analogrelay commented 6 years ago

Yes, this will go up to master as well.

vivmishra commented 6 years ago

Approved for 2.2.1

natemcmaster commented 6 years ago

Before this merges, we need to update branding on this repo. Please wait to merge until that is in.

BrennanConroy commented 6 years ago

I'm assuming branding is done and I can push? @natemcmaster

natemcmaster commented 6 years ago

Yes. We actually decided not to bump branding since this is a JS-only change, and can build separately from the .NET stuff. :shipit: