search

assert-rs / snapbox

Snapshot testing for a herd of CLI tests
docs.rs/trycmd
Apache License 2.0
138 stars 18 forks source link

fix: don't fail with overwrite #188

Closed figsoda closed 1 year ago

figsoda commented 1 year ago

fixes #31

figsoda commented 1 year ago

I will work on it after #189 is out of the way so I don't get merge conflicts

epage commented 1 year ago

@figsoda thinking about this more, this is an issue when the user is directly interacting with the program. The current behavior is a bug. What this PR introduces also has bugs. The question is which bug is worse. I think I lean towards the current behavior being worse. What do you think?

If we agree the current behavior is worse, we could possibly merge this now, open a new issue, and then work to get that new issue fixed. This would make it so people have the better experience sooner. Thoughts?

figsoda commented 1 year ago

I agree, the current behavior basically fails every single time on TRYCMD=overwrite and doesn't give much information as an interactive command