Closed joshuachp closed 7 months ago
Attention: Patch coverage is 73.97260%
with 57 lines
in your changes are missing coverage. Please review.
Project coverage is 67.9%. Comparing base (
fb0bc2f
) to head (65a6692
). Report is 1 commits behind head on master.
I propose the Value
for the name of the Aggregate
, this is the same name in the MQTT protocol (the v
field of the bson document).
This is because we are already "over-using" payload as the name of the body of a message/request in the transport structs.
Move the Unset to the
Aggregation
enum and introduce a newunset
method. This simplify the checks since you can only unset a property and the AstarteType::Unset is not needed in the others code paths. Also this simplifies the conversions in the gRPC code that now in infallible.