Closed Annopaolo closed 6 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.99%. Comparing base (
1a9c203
) to head (54cd7c9
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think that we should include also the
astarte-tools
to the publish to dockerhub workflow
@matt-mazzucato Not all tools are currently being built on all versions. For example, there exists only a snapshot
version of astarte_import. We should decide what to do for those. It would make sense to version everything, imo
It would make sense to version everything
@Annopaolo I agree with that!
It would make sense to version everything
@Annopaolo I agree with that!
@matt-mazzucato I checked if everything could be done in a single file. I got crazy. So, we'll have 4 files: release/snapshot and apps/tools.
Since now we are using the new docker build infra, the old image building and publishing workflow, based on dockerhub runners, is broken. Replace it with a new one, this time fully based on Github, to standardize the image publishing process.
DOCKER_USERNAME
andDOCKER_PASSWORD
of the registry must be added to repo secrets for this to work.In order to separate the flow of tagged and untagged builds, workflows are splitted: one works only on tags, the other on everyday push events. Examples:
release-1.2
, new images with1.2-snapshot
tag are built and pushed to astarte's dockerhub;master
branch, new images withsnapshot
tag are built and pushed to astarte's dockerhub;v1.2.0
, is made, new images with1.2.0
tag are build and pushed to astarte's dockerhubv1.2.0-rc.1
, is made, new images with1.2.0-rc.1
tag are build and pushed to astarte's dockerhubThis PR is based, based on #956.
Since this is not a small change, discussion on how/where/why to publish images is welcome.