asterics / AsTeRICS

The Assistive Technology Rapid Integration & Construction Set
http://www.asterics.eu
Other
57 stars 27 forks source link

Fixes #260: Threshold operationMode of type String #261

Closed deinhofer closed 6 years ago

deinhofer commented 6 years ago

What should be the default value for operationMode? binary?

klues commented 6 years ago

if the default was binary before, it maybe should remain the default, shouldn't it?

deinhofer commented 6 years ago

if the default was binary before, it maybe should remain the default, shouldn't it? Yes, but here the default value was 2 (deadzone) respectively.

But as I could not find any model in bin/ARE/models using the Threshold plugin, it might be irrelevant.

kingcole commented 6 years ago

looks good, thanks for fixing

I'd also go for binary as default a) to avoid problems and b) because it seems the more useful default

deinhofer commented 6 years ago

Ok, so I will merge it.