search

asteroid-team / asteroid

The PyTorch-based audio source separation toolkit for researchers
https://asteroid-team.github.io/
MIT License
2.21k stars 419 forks source link

Upgrade deprecated huggingface_hub.cached_download #645

Closed mattiadg closed 1 year ago

mattiadg commented 1 year ago

Fix #644 Removes the warning by following the upgrade instructions

mpariente commented 1 year ago

Thank you very much for the PR.

Have you tested it ?

In which version has the huggingface_hub.hf_hub_download been introduced ? Won't upgrading to it break asteroid's install for current users ?

mattiadg commented 1 year ago

I tried it manually and all the tests for cached_download continue to pass. I haven't yet checked in which version it was introduced, but it's present in the version you get from requirements.txt. We can investigate further though.

mpariente commented 1 year ago

Then it's perfect, thanks !