Closed JunzheJosephZhu closed 1 year ago
Looks good.
Can you use pre-commit please ?
hi, do you have a link to how to use pre-commit? never used it before
On Sun, May 28, 2023 at 00:48 Pariente Manuel @.***> wrote:
Looks good.
Can you use pre-commit please ?
— Reply to this email directly, view it on GitHub https://github.com/asteroid-team/asteroid/pull/668#issuecomment-1565591170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2C6G7FI3IB56ZDQGP3EJTXIIV6JANCNFSM6AAAAAAYP5BD6I . You are receiving this because you authored the thread.Message ID: @.***>
-- Joseph Zhu
You can check here : https://github.com/asteroid-team/asteroid/blob/master/CONTRIBUTING.md#coding-style
I think the "pre-commit" hyperlink in the page linked above doesn't work, but I just ran
pre-commit run --all-files
under asteroid root Hope this is correct
The PR has 64 files changed now. SO no, it's not ok.
Run it on the files you modified only.
And only python files.
k, I ran
pre-commit run --files egs/wsj0-mix-var/Multi-Decoder-DPRNN/*.py
instead. Hope this is correct.
ok, i cut it in half
People have been contacting me about not having a pytorch_model.bin file, so I made one, now this model can be loaded with a one-liner