asteroid-team / asteroid

The PyTorch-based audio source separation toolkit for researchers
https://asteroid-team.github.io/
MIT License
2.21k stars 419 forks source link

Add a colab notebook demo, and a separate script. Support from_pretrained for easier use. #668

Closed JunzheJosephZhu closed 1 year ago

JunzheJosephZhu commented 1 year ago

People have been contacting me about not having a pytorch_model.bin file, so I made one, now this model can be loaded with a one-liner

mpariente commented 1 year ago

Looks good.

Can you use pre-commit please ?

JunzheJosephZhu commented 1 year ago

hi, do you have a link to how to use pre-commit? never used it before

On Sun, May 28, 2023 at 00:48 Pariente Manuel @.***> wrote:

Looks good.

Can you use pre-commit please ?

— Reply to this email directly, view it on GitHub https://github.com/asteroid-team/asteroid/pull/668#issuecomment-1565591170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2C6G7FI3IB56ZDQGP3EJTXIIV6JANCNFSM6AAAAAAYP5BD6I . You are receiving this because you authored the thread.Message ID: @.***>

-- Joseph Zhu

mpariente commented 1 year ago

You can check here : https://github.com/asteroid-team/asteroid/blob/master/CONTRIBUTING.md#coding-style

JunzheJosephZhu commented 1 year ago

I think the "pre-commit" hyperlink in the page linked above doesn't work, but I just ran

pre-commit run --all-files

under asteroid root Hope this is correct

mpariente commented 1 year ago

The PR has 64 files changed now. SO no, it's not ok.

Run it on the files you modified only.

mpariente commented 1 year ago

And only python files.

JunzheJosephZhu commented 1 year ago

k, I ran

pre-commit run --files egs/wsj0-mix-var/Multi-Decoder-DPRNN/*.py

instead. Hope this is correct.

JunzheJosephZhu commented 1 year ago

ok, i cut it in half