astoff / devdocs.el

Emacs viewer for DevDocs
289 stars 17 forks source link

Assign `list-buffers-directory` to the entry name. #17

Closed nagy closed 2 years ago

nagy commented 2 years ago

This displays the entry name in M-x list-buffers instead of showing an empty path column.

astoff commented 2 years ago

This breaks the header line in the devdocs buffers. I just see a blank header line.

How about calling (format-mode-line devdocs-header-line) directly, so we don't need to define a new function?

nagy commented 2 years ago

This breaks the header line in the devdocs buffers. I just see a blank header line.

Sorry, I did not notice since I have those deactivated.

How about calling (format-mode-line devdocs-header-line) directly, so we don't need to define a new function?

This makes more sense. Thank you, I will try to fix that.

nagy commented 2 years ago

I have updated it and it is now a much smaller change.

astoff commented 2 years ago

It can be made even smaller :-). The optional arguments to format-mode-line are not needed, since you are passing the default values anyway.

nagy commented 2 years ago

I tried not passing those last values. It does not seem to work, for me at least. All I get is the separator symbol and nothing else. Is it the same for you if you remove those last values?

astoff commented 2 years ago

Ah, you are right. Usually the default for an optional buffer argument is the current buffer, but in this case it's the selected window buffer.

astoff commented 2 years ago

Thanks!