astraly-labs / astraly-contracts

Astraly Cairo Contracts
https://testnet.astraly.xyz
Creative Commons Zero v1.0 Universal
39 stars 12 forks source link

ERC1155 Lottery Tickets #4

Closed EvolveArt closed 2 years ago

EvolveArt commented 2 years ago

First complete draft of Lottery Tickets implementation as ERC1155 tokens.

ERC1155 standard taken from here and improved.

Some improvements are still to be made :

Some questions still to be answered:

EvolveArt commented 2 years ago

For on-chain trading, looks like we could take inspiration from realms-contracts

FilipLaurentiu commented 2 years ago

One thing to mention here. The standard in cairo is to name the contract where the logic is library.cairo ERC1155_base.cairo -> library.cairo Example

EvolveArt commented 2 years ago

One thing to mention here. The standard in cairo is to name the contract where the logic is library.cairo ERC1155_base.cairo -> library.cairo Example

Definitely! Fixed in https://github.com/ZkPad-Labs/zkpad-contracts/pull/4/commits/27427310629042e777aeae3ab74a5084c078f452