search

astronomer / astronomer-airflow-version-check

Plugin to check if new version of Astronomer Certified Airflow is available
Apache License 2.0
1 stars 2 forks source link

Manually pre-install wheel so cryptography gets installed from a wheel #33

Closed blag closed 2 years ago

blag commented 2 years ago

Instead of installing a bunch of binary packages so pip can successfully install the cryptography C shims, this PR minimizes the number of installed packages, and pre-installs wheel into the virtualenv so that pip can use the wheel packages of cryptography.

I manually tested the verify tag commands on bare metal macOS as well as within a Docker container.

Using wheel packages is likely going make our build and deploy process slightly more resilient than installing binary packages and compiling cryptography each time (as the Docker image may get updated out from under us and binary package names may change around).

blag commented 2 years ago

This is expanding the scope of this PR a little bit, but I also install g++ to build greenlet.

That fixes this build error.

I have manually tested this in the Alpine Docker container that the publish step runs.

This PR is RFR and merge.