search

astronomer / dag-factory

Dynamically generate Apache Airflow DAGs from YAML configuration files
Apache License 2.0
1.21k stars 183 forks source link

Remove unnecessary config line #202

Closed jlaneve closed 4 months ago

jlaneve commented 4 months ago

I'm pretty sure this is a mistake so removing it.

cmarteepants commented 4 months ago

Ah I see yes there is a typo. However, the task_2 key should be there so the config matches the example in the screenshot. [custom_operators.png](..%2F..%2FDesktop%2Fcustom_operators.png) should not. It should be:

    task_2:
      operator: airflow.operators.bash_operator.BashOperator
      bash_command: "echo 2"
      dependencies: [ task_1 ]

We can either reopen the PR and re-add the task_2 key, or remove the rest of the task_2 config and update the screenshot.

cmarteepants commented 4 months ago

Went with the former as it was easier