search

astronomer / dag-factory

Dynamically generate Apache Airflow DAGs from YAML configuration files
Apache License 2.0
1.21k stars 183 forks source link

Remove off looking start-date value in example_dag yaml config #273

Closed pankajkoti closed 1 month ago

pankajkoti commented 1 month ago

The example_dag in the example_dag_factory.yml has a start_date value set to 2 days, which seems unclear and problematic. It’s not clear what this value represents, and it appears to be causing issues with the DAG, preventing it from running tasks. I confirmed this issue also exists in version 0.19.0, so it’s not related to any changes made after that version. When I removed this questionable start_date value, the DAG ran its tasks successfully.

closes: #274

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.96%. Comparing base (a947aa8) to head (6e1ccb7). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #273 +/- ## ======================================= Coverage 93.96% 93.96% ======================================= Files 8 8 Lines 630 630 ======================================= Hits 592 592 Misses 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pankajkoti commented 1 month ago

shall we remove end_date: 2018-03-05 too?

I guess we can keep it, it does not harm us, DAG runs are created & run fine until that end_date. And since we have been having it as example like this, I guess good to keep it as is without making much changes. WDYT?

pankajkoti commented 1 month ago

shall we remove end_date: 2018-03-05 too?

I guess we can keep it, it does not harm us, DAG runs are created & run fine until that end_date. And since we have been having it as example like this, I guess good to keep it as is without making much changes. WDYT?

As discussed over Slack, I feel it's good to have that start_date - end_date time window to demonstrate that we're able to run DAGs using DAG factory (accepting those params well), so I'm going ahead with the merge. If the need is to support manual DAG runs, I suggest we create & add another example DAG without having an end_date, but for the given example I strongly believe it's a good example to have an end_date. I am going ahead with the merge now. Thanks for the review & the question :)