search

astropy / extension-helpers

Helpers to assist with building Python packages with compiled C/Cython extensions
https://extension-helpers.readthedocs.io
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Support for `pyproject.toml` configuration #47

Closed WilliamJamieson closed 1 year ago

WilliamJamieson commented 1 year ago

In this https://github.com/astropy/astropy/pull/14361#issuecomment-1419210239, it was requested that extension-helpers support something like:

[extension-helpers]
use_extension_helpers = true

configurations, but in the pyproject.toml instead of the setup.cfg. This is so that projects like astropy can move towards adopting PEP621 (storing all project metadata in pyproject.toml instead of across the setup.cfg and setup.py files).

WilliamJamieson commented 1 year ago

Note, if there are no objections to adding this as an option, I'll give it a shot.

astrofrog commented 1 year ago

No objections from me as long as it doesn't add too much complexity.

WilliamJamieson commented 1 year ago

I think it would just require a (possibly optional) dependency on tomli for python < 3.11 (enough of tomli is part of python 3.11 for it to work).

astrofrog commented 1 year ago

That seems reasonable