search

astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 40 forks source link

Fix compatibility of conftest.py with Astropy 3.2 #136

Closed astrobot closed 5 years ago

astrobot commented 5 years ago

:page_with_curl: About this pull request

Hi there :wave:, it looks like you likely used the astropy package template in the past for your package and we noticed that your conftest.py file is now out of date and imports pytest plugins from astropy:

from astropy.tests.pytest_plugins import *

This astropy sub-package has been removed, so your tests will likely be failing now that astropy v3.2 has been released. This PR therefore fixes this import by checking the astropy version and adjusting the import as needed.

:loudspeaker: For info: updates to the package template

We also wanted to let you know that we have made new releases of the astropy package-template. If your package still needs to support Python 2, you can find the latest Python 2-compatible cookiecutter template here or if you prefer you can find a rendered version of the template here.

If you only need to support Python 3, you can find the latest cookiecutter template here or if you prefer you can find a rendered version of the template here.

If you need any help with updating your package to the latest package template, don't hesitate to ping @astrofrog or @bsipocz and we can try and help.

If you do not want to make this change for now, feel free to close the pull request

Thanks! :robot: :wave:

If there are issues with this pull request, please ping @astrofrog

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 63.768% when pulling 34ca00f8b4fbae802460e79c6077b3a7beebabd3 on astrobot:fix-pytest-plugins-import into 913af7ea4917855cb2e43d5086d1c8dd99c31363 on astropy:master.

smaret commented 5 years ago

Could you please merge this? Tests are currently broken in master.

bsipocz commented 5 years ago

I go ahead and merge this despite the failure, as those are already present on master and this PR actually fixes a few jobs in the matrix.

bsipocz commented 5 years ago

@smaret - there are still issues around, but nevertheless I've merged all the infrastructure PRs that fixed some of those, or at least didn't leave the master in a worse condition than it already was.