search

astropy / specreduce

Tools for the reduction of spectroscopic observations from Optical and NIR instruments
https://specreduce.readthedocs.io
62 stars 38 forks source link

Add default and set to zero masking option for specreduce operations. #216

Open cshanahan1 opened 7 months ago

cshanahan1 commented 7 months ago

(incomplete draft, just look at tracing and background for now)

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (6b8e995) to head (b967d8d). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
specreduce/core.py 96.42% 1 Missing :warning:
specreduce/tracing.py 97.29% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== + Coverage 83.37% 83.97% +0.60% ========================================== Files 13 13 Lines 1137 1186 +49 ========================================== + Hits 948 996 +48 - Misses 189 190 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

tepickering commented 4 months ago

finally got a chance to at least look through the code changes. i like it so far! let me know when it's ready for a fuller review and i'll try playing with it in more depth.

camipacifici commented 4 months ago

I am pretty sure it is! Please go ahead. Thank you!

tepickering commented 2 months ago

there are a bunch of warnings in the RTD build. they look like malformed references, but need a deeper look to see what's the actual cause.

tepickering commented 2 months ago

i'm confused why python 3.8 and 3.9 tests are being run. a rebase might be needed, though i thought this was forked after those tests were removed.