search

astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
170 stars 127 forks source link

Fix bug handling subregions in true_excise #1170

Closed rosteen closed 2 months ago

rosteen commented 2 months ago

Looking into #1167 led me to realize that the subregion handling in true_excise was actually using the upper and lower bounds from the full region rather than each subregion. This fixes that. I'll add a test tomorrow that would have caught this, since right now it looks like all tests still pass with the change.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.89%. Comparing base (173d806) to head (8edb04c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1170 +/- ## ======================================= Coverage 86.89% 86.89% ======================================= Files 63 63 Lines 4547 4547 ======================================= Hits 3951 3951 Misses 596 596 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rosteen commented 2 months ago

I'm actually going to close this without merging, I didn't realize true_excise is not available to call independently from excise_regions, and the current behavior is as documented. Might be worth a deeper revisit sometime but for now I'll leave it as-is.