astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
170 stars 127 forks source link

Add option to have inclusive upper boundaries in fitting/excision. #1171

Closed rosteen closed 2 months ago

rosteen commented 2 months ago

Supersedes #1168 by making this behavior an optional toggle in fit_models, fit_continuum, and excise_regions rather than changing the default.

Closes #1167.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.84%. Comparing base (016ffc2) to head (c3914a4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1171 +/- ## ========================================== - Coverage 86.87% 86.84% -0.04% ========================================== Files 63 63 Lines 4549 4553 +4 ========================================== + Hits 3952 3954 +2 - Misses 597 599 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rosteen commented 2 months ago

Test failures are unrelated, I'm going to go ahead and merge.