search

astrosonic / sanctuary

A secure synchronous lightweight chatroom with zero logging and total transience
GNU General Public License v3.0
54 stars 11 forks source link

Single process HTTP and WS server using multithreading #68

Closed amaank404 closed 3 years ago

amaank404 commented 4 years ago

There are many changes (I have single threaded the server). Also the thing is that i used isort and black over it so it got beautifully formatted

fixes: #65

gridhead commented 4 years ago

Thanks for your prompt pull request @xcodz-dot. Give us some time to review your contribution while feel free to take a look at other issues as well.

I could use an assistance in reviewing this PR @VaibhavSaini19 @s-katte @khallnayak.

amaank404 commented 3 years ago

yeah, sure (You can try it locally if you would like to check it)

gridhead commented 3 years ago

yeah, sure (You can try it locally if you would like to check it)

Sure. But as this is now a community project, I would also appreciate folks looking into the changes as well. :smile:

amaank404 commented 3 years ago

great 😄

amaank404 commented 3 years ago

@xcodz-dot, functionality is working perfect, just a few changes requested:

  • [x] remove linting from all the pages ( as we follow atomic PRs )
  • [ ] feel free to create another issue if there is not any regarding linting of code.

I will remove linting

gridhead commented 3 years ago

There are many changes (I have single threaded the server). Also the thing is that i used isort and black over it so it got beautifully formatted

Also, just one small correction (not to the code though) - what you have done right now has made the server a single process by the use of multithreading, in contrary to the stated PR title. servchat and chatroom both now run as threads under a single process called sanctuary.

amaank404 commented 3 years ago

I think that readme would need an update

gridhead commented 3 years ago

I think that readme would need an update

Yes, it does. Feel free to open an issue and have yourself assigned to it, if you want. :smile:

amaank404 commented 3 years ago

Well i will surly do it once I am done previous requested features (issues)

amaank404 commented 3 years ago

I think this can be moved to done

amaank404 commented 3 years ago

https://github.com/astrosonic/sanctuary/projects/1#card-42325403 this card can be moved?