search

asulwer / RulesEngine

Rules Engine with extensive Dynamic expression support
MIT License
26 stars 1 forks source link

Move to Central Package Management (CPM) #69

Closed HalvorNygaard closed 1 month ago

HalvorNygaard commented 1 month ago

Could consider to move over to CPM. This way all the dependency versioning would be managed from one file (Directory.Packages.props) on solution root. Since the projects in the solution don't have that many overlapping dependencies its not that big of a deal, but its kind of nice either way.

https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

HalvorNygaard commented 1 month ago

I do have the changes changes necessary in a local branch, could push them up if i get access.

This test seem to fail for the branch, but it also fails on main: RulesEngineWithGlobalParam_RunsSuccessfully(ruleFileName: "rules11.json")

asulwer commented 1 month ago

@HalvorNygaard we are using github to centrally manage dependencies. in my opinion, it doesn't seem to be working as expected though. @RenanCarlosPereira is more familiar with dependabot

@HalvorNygaard this suggestion would be useful if we used the same dependencies across projects. typically i use the solution explorer to manage dependencies for all of the projects. in my opinion this serves the same purpose.

asulwer commented 1 month ago

@HalvorNygaard here is the dependabot in question that updates packages. @RenanCarlosPereira it appears it is not updating nuget packages? should we enable this?

RenanCarlosPereira commented 1 month ago

yes that should be enabled