search

async-aws / aws

AWS SDK with readable code and async responses
https://async-aws.com
MIT License
436 stars 132 forks source link

Add SQS AddPermission operation #1773

Closed stevenbrookes closed 1 month ago

stevenbrookes commented 2 months ago

New SQS AddPermission operation, required to allow 3rd parties the permission to send messages to queues created using the createQueue endpoint.

I didn't seem to need to do anything after using the generate script - very cool. Let me know if I've missed anything.

As it looks like you are using a monorepo how would I go about using my fork of that in my code while the PR is reviewed and hopefully accepted.

Thanks

Steve

GrahamCampbell commented 2 months ago

I didn't seem to need to do anything after using the generate script - very cool. Let me know if I've missed anything.

You need to write the tests.

stevenbrookes commented 2 months ago

Test added. I seem to be failing the change log test. I added an entry, but perhaps not the right format? Any advice?

jderusse commented 2 months ago

Test added. I seem to be failing the change log test. I added an entry, but perhaps not the right format? Any advice?

You can ignore the @dev suite (it should be fixed by #1771 )

The @stable just need an entry in the CHANGELOG file (you should add a ### Added section and a descript of your change)

jderusse commented 1 month ago

The last failing test is about bumping the minor version.

Because this PR adds a new feature, the next version of the package will change. You need to edit the src/Service/Sqs/composer.json file and set 2.2-dev in the branch-alias section

stevenbrookes commented 1 month ago

Yay finally passed the tests. May I suggest adding the additional things that need to be done to the contributing documentation so aid future contributors? I look forward to this PR being accepted.

jderusse commented 1 month ago

thank you @stevenbrookes

Please yes, fill free to improve the documentation :pray: